Add stop and kill actions for orchestration pills#10526
Open
Add stop and kill actions for orchestration pills#10526
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR adds Stop and Kill actions for orchestration child-agent pills, including local/cloud cancellation paths, synthetic cancellation lifecycle events, killed-run tombstones, pane teardown, and unit tests.
Concerns
- The new
emit_child_killedunit tests callstart_new_child_conversationwithout the requiredorchestration_harnessargument, so the test target will not compile.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
…chestration-pills-20260507
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loom: https://www.loom.com/share/a76dedd771264a1a9d04df7b00c8f34c
Resolves https://linear.app/warpdotdev/issue/QUALITY-604/stopkill-agents-ui-with-correct-behavior-for-orchestration
Description
Adds Stop and Kill actions to child-agent orchestration pill overflow menus. Stop is a non-destructive cancellation action that leaves the child transcript/pane available for inspection; Kill is a destructive local teardown action that removes the child from the user's workspace after cancelling it if needed.
Stop vs Kill
Cancelledlifecycle event, tombstones the child's run ID so late events are ignored, then discards the child pane/conversation locally.Technical Design
Stop and Kill share the same high-level resolution path: look up the child conversation's owner/task state, then route to either local terminal cancellation or cloud ambient-task cancellation. Stop is intentionally gated to in-progress children and keeps all local UI state intact, while Kill is always available because its primary meaning is "remove this child from my local workspace"; cancellation is only attempted when the child is still running.
For orchestration v2, Kill emits a final local
Cancelledlifecycle event before removing the child so the parent agent can observe that the child was killed. It also records killed run IDs as bounded tombstones and filters late SSE events/messages from those runs, preventing deleted children from being resurrected by buffered server events while keeping the tombstone memory footprint capped.Testing
Added unit tests
Validation run on this branch:
cargo fmtcargo test -p warp --lib orchestration_events -- --nocapturecargo test -p warp --lib orchestration_event_streamer -- --nocapturecargo check -p warpgit --no-pager diff --check